[PATCH] D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC.

Artem Dergachev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 23 13:16:39 PDT 2019


NoQ marked an inline comment as done.
NoQ added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:42
                                 const LangOptions &LangOpts) {
+  // FIXME: This logic breaks when there is a comment with ':'s in the middle.
   CharSourceRange TextRange =
----------------
Added a similar comment here because this also seems flaky.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59977/new/

https://reviews.llvm.org/D59977





More information about the llvm-commits mailing list