[lld] r358990 - [LLD][ELF] - Remove dynamic-section-sh_size.elf binary, convert test to yaml. NFCI.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 23 07:21:31 PDT 2019


Author: grimar
Date: Tue Apr 23 07:21:31 2019
New Revision: 358990

URL: http://llvm.org/viewvc/llvm-project?rev=358990&view=rev
Log:
[LLD][ELF] - Remove dynamic-section-sh_size.elf binary, convert test to yaml. NFCI.

dynamic-section-sh_size.elf was introduced in D25090.
Now it is possible to use yaml2obj instead. 
That is what this patch does.

Also I added one more case of a possibly broken .dynamic
section just in case.

Added:
    lld/trunk/test/ELF/invalid/dynamic-section-broken.test
Removed:
    lld/trunk/test/ELF/invalid/Inputs/dynamic-section-sh_size.elf
    lld/trunk/test/ELF/invalid/dynamic-section-size.s

Removed: lld/trunk/test/ELF/invalid/Inputs/dynamic-section-sh_size.elf
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/invalid/Inputs/dynamic-section-sh_size.elf?rev=358989&view=auto
==============================================================================
Binary file - no diff available.

Added: lld/trunk/test/ELF/invalid/dynamic-section-broken.test
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/invalid/dynamic-section-broken.test?rev=358990&view=auto
==============================================================================
--- lld/trunk/test/ELF/invalid/dynamic-section-broken.test (added)
+++ lld/trunk/test/ELF/invalid/dynamic-section-broken.test Tue Apr 23 07:21:31 2019
@@ -0,0 +1,36 @@
+## .dynamic section has invalid sh_entsize, check we report it.
+# RUN: yaml2obj -docnum=1 %s -o %t.so
+# RUN: not ld.lld %t.so -o /dev/null 2>&1 | FileCheck %s --check-prefix=ERR1
+# ERR1: error: {{.*}}.so: invalid sh_entsize
+
+--- !ELF
+FileHeader:
+  Class:           ELFCLASS64
+  Data:            ELFDATA2LSB
+  Type:            ET_DYN
+  Machine:         EM_X86_64
+Sections:
+  - Name:          .dynamic
+    Type:          SHT_DYNAMIC
+    Flags:         [ SHF_ALLOC ]
+    Link:          .strtab
+    EntSize:       0x123
+
+## The  .dynamic section has invalid sh_size, which is too short and
+## even less than entry size. Check we report it.
+# RUN: yaml2obj -docnum=2 %s -o %t.so
+# RUN: not ld.lld %t.so -o /dev/null 2>&1 | FileCheck %s --check-prefix=ERR2
+# ERR2: error: {{.*}}.so: size is not a multiple of sh_entsize
+
+--- !ELF
+FileHeader:
+  Class:           ELFCLASS64
+  Data:            ELFDATA2LSB
+  Type:            ET_DYN
+  Machine:         EM_X86_64
+Sections:
+  - Name:          .dynamic
+    Type:          SHT_DYNAMIC
+    Flags:         [ SHF_ALLOC ]
+    Link:          .strtab
+    Content:       "00"

Removed: lld/trunk/test/ELF/invalid/dynamic-section-size.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/invalid/dynamic-section-size.s?rev=358989&view=auto
==============================================================================
--- lld/trunk/test/ELF/invalid/dynamic-section-size.s (original)
+++ lld/trunk/test/ELF/invalid/dynamic-section-size.s (removed)
@@ -1,4 +0,0 @@
-## dynamic-section-sh_size.elf has incorrect sh_size of dynamic section.
-# RUN: not ld.lld %p/Inputs/dynamic-section-sh_size.elf -o /dev/null 2>&1 | \
-# RUN:   FileCheck %s
-# CHECK: error: {{.*}}: invalid sh_entsize




More information about the llvm-commits mailing list