[PATCH] D60981: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.1
Dmitry Vyukov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 23 05:12:06 PDT 2019
dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.
JmpBufGarbageCollect uses <= on sp values to detect bufs that are no longer active. But as far as I understand we still will able to do this, right?
It can make sense to combine the first part of LongJmp that extracts sp from context with UnmangleLongJmpSp in future changes, because they have effectively the same set of checks on OS/arch. E.g. GetSPFromContext that will both extract and demangle it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60981/new/
https://reviews.llvm.org/D60981
More information about the llvm-commits
mailing list