[PATCH] D60636: [CallSite removal] move InlineCost to CallBase usage

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 23 05:02:33 PDT 2019


fedor.sergeev marked 2 inline comments as done.
fedor.sergeev added inline comments.


================
Comment at: llvm/lib/Analysis/InlineCost.cpp:2095
+      if (!ReturnsTwice && isa<CallInst>(Call) &&
+          cast<CallInst>(Call)->canReturnTwice())
         return "exposes returns-twice attribute";
----------------
reames wrote:
> Doesn't look like you need the cast to CallInst here.
canReturnTwice is CallInst member, it is not available for CallBase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60636/new/

https://reviews.llvm.org/D60636





More information about the llvm-commits mailing list