[PATCH] D32530: [SVE][IR] Scalable Vector IR Type

David Greene via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 22 12:12:41 PDT 2019


greened added a comment.

In D32530#1470784 <https://reviews.llvm.org/D32530#1470784>, @hfinkel wrote:

> In D32530#1470773 <https://reviews.llvm.org/D32530#1470773>, @greened wrote:
>
> >
>




>> I am not sure how it could be anything but `n`.  If you don't know how long the vector is, you can't correctly generate an index beyond `n`.
> 
> But you know at runtime... there has to be a way to determine, at runtime, vscale. And the index doesn't need to be a constant. I'm not sure that we need to restrict non-constant n to only values valid for vscale == 1.

Good point.  100% agree.  I was only considering the constant case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D32530/new/

https://reviews.llvm.org/D32530





More information about the llvm-commits mailing list