[PATCH] D60294: [DAGCombiner] [CodeGenPrepare] WIP/RFC Splitting large offsets from base addresses

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added a comment.

Those test case changes represent an actual improvement here, so this looks good.   Thanks!



================
Comment at: test/CodeGen/SystemZ/int-add-08.ll:53
 ; CHECK-LABEL: f4:
-; CHECK: lgr [[BASE:%r[1-5]]], %r3
-; CHECK: agfi [[BASE]], 524288
-; CHECK: alg {{%r[0-5]}}, 0([[BASE]])
+; CHECK: lay {{%r[0-5]}}, 524280(%r3)
+; CHECK: alg {{%r[0-5]}}, 8({{%r[1-5]}})
----------------
It would be preferable to keep verifying the base register here, i.e.

```
  lay [[BASE::%r[1-5]]], 524280(%1)
  alg {{%r[0-5]}}, 8([[BASE]])
```



================
Comment at: test/CodeGen/SystemZ/int-sub-05.ll:58
 ; CHECK-LABEL: f4:
-; CHECK: lgr [[BASE:%r[1-5]]], %r2
-; CHECK: agfi [[BASE]], 524288
-; CHECK: slg {{%r[0-5]}}, 0([[BASE]])
+; CHECK: lay {{%r[0-5]}}, 524280(%r2)
+; CHECK: slg {{%r[0-5]}}, 8({{%r[0-5]}})
----------------
Same here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60294/new/

https://reviews.llvm.org/D60294