[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

Mon Apr 22 21:46:02 PDT 2019

liutianle added a comment.

In D60408#1474100 <https://reviews.llvm.org/D60408#1474100>, @ymandel wrote:

> In D60408#1473370 <https://reviews.llvm.org/D60408#1473370>, @liutianle wrote:
>
> > hi ymandel,
> >  When I run "check-all", there are some warning/error in TransformerTest.cpp as follow. My version is llvm:0ee120077 and clang:d87ee8e678. Could you please have a fix or guild me how to fix it?
> >
> >  -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> >
> > In file included from myLLVM/llvm/utils/unittest/googlemock/include/gmock/internal/gmock-internal-utils.h:47:0,
> >
> >   from myLLVM/llvm/utils/unittest/googlemock/include/gmock/gmock-actions.h:46,
> >   from myLLVM/llvm/utils/unittest/googlemock/include/gmock/gmock.h:58,
> >   from myLLVM/llvm/tools/clang/unittests/Tooling/TransformerTest.cpp:13:
> >
> > myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest.h: In instantiation of 'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = long unsigned int; T2 = int]':
> >  myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest.h:1421:23:   required from 'static testing::AssertionResult testing::internal::EqHelper<lhs_is_null_literal>::Compare(const char*, const char*, const T1&, const T2&) [with T1 = long unsigned int; T2 = int; bool lhs_is_null_literal = false]'
> >  myLLVM/llvm/tools/clang/unittests/Tooling/TransformerTest.cpp:372:3:   required from here
> >  myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest.h:1392:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
> >
> >   if (lhs == rhs) {
> >           ^
> >
> >  ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>
> Sorry about that. Have you sync'd to head? I thought that was fixed with r358745 (from Bjorn Pettersson).

I see. Thank you very much!

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60408/new/

https://reviews.llvm.org/D60408