[PATCH] D60932: [NFC] Add baseline tests for int isKnownNonZero
Dan Robertson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 22 11:23:25 PDT 2019
dlrobertson marked an inline comment as done.
dlrobertson added a comment.
In D60932#1474266 <https://reviews.llvm.org/D60932#1474266>, @nikic wrote:
> Probably also a good time to request commit access, see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access for instructions.
Will do!
================
Comment at: llvm/test/Transforms/InstCombine/cttz.ll:31
+ ret i32 %res
+}
----------------
nikic wrote:
> It would be good to also test the ctlz case here. Possibly with a vector type, so we have at least one test that checks this transform with a vector zero.
+1 sounds good
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60932/new/
https://reviews.llvm.org/D60932
More information about the llvm-commits
mailing list