[PATCH] D60945: [ELF][X86] Allow R_386_TLS_LDO_32 and R_X86_64_DTPOFF{32,64} to preemptable local-dynamic symbols

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

OK, then moving just below



================
Comment at: ELF/InputSection.cpp:618
   case R_RELAX_GOT_PC_NOPIC:
     return Sym.getVA(A);
+  case R_DTPREL:
----------------
MaskRay wrote:
> ruiu wrote:
> > I mean you could merge with this expression as this is the same expression as yours.
> It will be changed. In PPC64 and MIPS there is an offset.
OK, but then moving this expression here doesn't make sense. I guess my point is to not make the code too future-proof. You can merge them and split it later, so that the code doesn't odd when you submit this. It's already committed, and it's not important, so I'm fine with this code for now though.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60945/new/

https://reviews.llvm.org/D60945