[PATCH] D60616: Make parseBitcodeFile use a named StructType, if it exists and matches.
Arnt Gulbrandsen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 21 12:47:58 PDT 2019
arnt marked an inline comment as done.
arnt added a comment.
Thanks.
FWIW I noticed that the author of the git-commit hook suggested using an emacs-lisp clang-format wrapper, and decided to try that first, until I grow unhappy.
================
Comment at: llvm/unittests/Bitcode/BitReaderTest.cpp:217
+ EXPECT_FALSE(F2 == nullptr);
+ EXPECT_TRUE(cast<StructType>(F2->getReturnType())->getName()==T1->getName());
+
----------------
lebedev.ri wrote:
> `EXPECT_EQ()` / `EXPECT_ME()` ?
Yes, OK, will fix, although YAGNI and so on.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60616/new/
https://reviews.llvm.org/D60616
More information about the llvm-commits
mailing list