[PATCH] D60052: Add Connex vector processor back end

[Alex Susu via Phabricator via llvm-commits]

alexsusu added a comment.

In D60052#1471560 <https://reviews.llvm.org/D60052#1471560>, @asb wrote:

> Some initial feedback:
>
> - This patch is pretty huge which makes it pretty hard to meaningfully review
> - There seem to be effectively no tests. I'd expect test/CodeGen/Connex and test/MC/Connex to be reasonably well populated
> - Plenty of code commented out or with date-based comments that don't match our style, e.g. `// 2018_*`
> - Files have the old license header rather than the new one


Hi, Alex.

  I addressed a few of your concerns and I'm working on the others.
  
  An important thing is that I think test/MC/Connex should not be populated for this patch, because the Connex back end is able to generate only an assembly code that is required to be used by the special Opincaa assembler, which is not integrated in LLVM. I've seen other back ends doing a similar thing such as the NVPTX back end, which doesn't support object file generation. The Connex back end also doesn't support object file generation.
  
  Thank you,
    Alex Susu


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60052/new/

https://reviews.llvm.org/D60052