[PATCH] D60927: [WIP][llvm-objdump] Switch between ARM/Thumb based on mapping symbols.

[Stephen Hines via Phabricator via llvm-commits]

srhines added a comment.

I added Peter and Oliver since they might have some suggestions here too.



================
Comment at: lib/Target/ARM/Disassembler/ARMDisassembler.cpp:441
                                              raw_ostream &CS) const {
+  if (STI.getFeatureBits()[ARM::ModeThumb])
+    return getThumbInstruction(MI, Size, Bytes, Address, OS, CS);
----------------
Add logic to check if you are defaulting to Thumb mode here (i.e. that was the triple that was passed).


================
Comment at: lib/Target/ARM/Disassembler/ARMDisassembler.cpp:869
   TargetRegistry::RegisterMCDisassembler(getTheThumbLETarget(),
-                                         createThumbDisassembler);
+                                         createARMDisassembler);
   TargetRegistry::RegisterMCDisassembler(getTheThumbBETarget(),
----------------
Wouldn't this be easier to fix by retaining a `createThumbDisassembler` that calls a shared `createARMThumbDisassembler` with a flag to denote the default case for disassembly?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60927/new/

https://reviews.llvm.org/D60927