[PATCH] D60931: [builtins] Use aliases for function redirects

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 20 06:03:33 PDT 2019


mstorsjo added a reviewer: rnk.
mstorsjo added a comment.

Works fine for mingw setups.

However, the alias mechanism used for MSVC, alternatename directives, doesn't quite work the right way for compiler-rt. If the object file containing the alternatename directive hasn't been brought in by some other symbol, the linker won't find the alias symbol at all.

Normally, I would presume that compiler-rt builtins aren't used in MSVC style builds though, but I'm not sure if we want to exclude them outright either. Reid, do you have opinions or creative ideas? (Afaik, the gnu alias attribute will work with clang-cl, but not with MSVC proper.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60931/new/

https://reviews.llvm.org/D60931





More information about the llvm-commits mailing list