[PATCH] D60036: [CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw.

[Luqman Aden via Phabricator via llvm-commits]

luqmana added a comment.

In D60036#1454548 <https://reviews.llvm.org/D60036#1454548>, @nikic wrote:

> We should probably give reenabling the option by default another try (in a separate revision), at least I can't seem to reproduce the issue in PR31181 anymore.


PR31181 still repros for me:

With the nowrap flag marking disabled (default):

  ➜  llc -o PR31181.opt.s PR31181.opt.bc
  ➜  opt -instcombine -early-cse -jump-threading -correlated-propagation -loop-rotate -indvars -gvn -o PR31181.opt.bc PR31181.bc
  ➜  llc -o PR31181.opt.s PR31181.opt.bc                                                                                        
  ➜  gcc -o PR31181 PR31181.opt.s
  ➜  timeout -s 9 10 ./PR31181

Enabling nowrap flag marking:

  ➜  opt -instcombine -early-cse -jump-threading -correlated-propagation -loop-rotate -indvars -gvn -cvp-dont-add-nowrap-flags=false -o PR31181.opt.bc PR31181.bc
  ➜  llc -o PR31181.opt.s PR31181.opt.bc
  ➜  gcc -o PR31181 PR31181.opt.s
  ➜  timeout -s 9 10 ./PR31181
  [1]    5928 killed     timeout -s 9 10 ./PR31181


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60036/new/

https://reviews.llvm.org/D60036