[PATCH] D60642: [dsymutil] Collect parseable Swift interfaces in the .dSYM bundle.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFFormValue.h:169
+                             StringRef Default = {}) {
+  if (V)
+    if (auto S = V->getAsCString())
----------------
JDevlieghere wrote:
> Early return?
I'm not convinced that this is much better. What do you think?

```
if (!V)
  return Default;

const char *Str = V->getAsCString()
if (!Str)
  return Default;

return Str;
```


================
Comment at: llvm/tools/dsymutil/CompileUnit.h:322
+  /// The DW_AT_language of this unit.
+  uint16_t Language = 0;
+
----------------
JDevlieghere wrote:
> dwarf::SourceLanguage? 
Unfortunately SourceLanguage neither has a storage class nor an enumerator for `0` defined.


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:273
+      DWARFDie CUDie = CU.getOrigUnit().getUnitDIE();
+      auto ResolvedPath = resolveObjectPath(CUDie, Path);
+      sys::path::append(ResolvedPath, Path);
----------------
JDevlieghere wrote:
> Since it's passed already, can the helper append the path? 
No, the other user needs them separate. I tried to make the interface slightly less weird.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60642/new/

https://reviews.llvm.org/D60642