[PATCH] D60924: [ThinLTO] Adding architecture name into saved object filename

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

In D60924#1473176 <https://reviews.llvm.org/D60924#1473176>, @steven_wu wrote:

> In D60924#1473166 <https://reviews.llvm.org/D60924#1473166>, @dexonsmith wrote:
>
> > In D60924#1473161 <https://reviews.llvm.org/D60924#1473161>, @steven_wu wrote:
> >
> > > In D60924#1473135 <https://reviews.llvm.org/D60924#1473135>, @dexonsmith wrote:
> > >
> > > > Is there a good way to test this?
> > >
> > >
> > > Not currently in LLVM. It might be possible to add a test in clang repo which requires DARWIN and ld64.
> >
> >
> > Maybe we can split out the function to generate the filename, and add a unit test for that?
>
>
> That almost looks like a test for path::append. Not sure if there is much value to add that.


What about an `llvm-lto` test?  Is there a way to make it trigger this case?

My concern is that this is a subtle requirement, and it would be easy to regress without a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60924/new/

https://reviews.llvm.org/D60924