[PATCH] D60734: [gn] Support dots in CMake paths in the sync script

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/CMakeLists.txt:122
   sanitizer_common_interceptors_ioctl.inc
-  sanitizer_common_interceptors_vfork_aarch64.inc.S
   sanitizer_common_interface.inc
----------------
phosek wrote:
> thakis wrote:
> > Are you intentionally removing this?
> After the `sync_source_lists_from_cmake.py` change, this one is being flagged, but there are other headers like this one for other architectures, e.g. [sanitizer_common_interceptors_vfork_x86_64.inc.S](https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_vfork_x86_64.inc.S), none of which are listed in the CMake file, so I figured it's better to remove this one to make this file self-consistent.
Ok, looks like this file is included somewhere and removing it here shouldn't change the build. Maybe .S.inc would be a better name :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60734/new/

https://reviews.llvm.org/D60734