[PATCH] D60887: [AsmPrinter] refactor to support %c w/ GlobalAddress'

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers marked an inline comment as done.
nickdesaulniers added a comment.

When I added test cases for RISCV and AVR, I got the following error message from `llvm-lit` that I don't understand:

  UNSUPPORTED: LLVM :: CodeGen/RISCV/inlineasm-output-template.ll (1 of 1)
  UNSUPPORTED: LLVM :: CodeGen/AVR/inlineasm-output-template.ll (1 of 1)

I'm not setting `-DLLVM_TARGETS_TO_BUILD` `cmake` variable, so I guess these backends are defaulted off or something?



================
Comment at: llvm/test/CodeGen/NVPTX/inlineasm-output-template.ll:12
+; Test that %c works with global address
+; FIXME: seems this case isn't handled properly by
+; SelectionDAG TargetLowering::LowerAsmOperandForConstraint?
----------------
I'm not particularly happy about this, but didn't have enough background with SelectionDAG to quickly understand the issue.  Please let me know if I should drop this added but commented out test case from this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60887/new/

https://reviews.llvm.org/D60887