[PATCH] D60882: [WebAssembly] Error on relocations against undefined data symbols.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Although I understand that reporting an error is sometimes useful, are you sure that that's the behavior that users want? I wonder if we would end up adding `--really-allow-undefined` in the future to override this new behavior.



================
Comment at: lld/wasm/InputFiles.cpp:144
+  const Symbol* Sym = nullptr;
+  if (Reloc.Type != R_WASM_TYPE_INDEX_LEB) {
+    Sym = Symbols[Reloc.Index];
----------------
Can you add a comment for this code block?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60882/new/

https://reviews.llvm.org/D60882