[PATCH] D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 16:40:29 PDT 2019


chandlerc added a comment.

In D60833#1472319 <https://reviews.llvm.org/D60833#1472319>, @asbirlea wrote:

> Simplify patch to preserve MemorySSA in the old pass manager only when the pass is already available (remove *require*).
>  New pass manager does not preserve it.


Ugh.

Ok, I want to revisit a suggestion I made previously: maybe let's just not enable MemorySSA by default in the old pass manager? Given that it forces you to add all of this code and complexity, it seems like we should just leave it off-by-default there, and enable it by default in the new pass manager only.

Other than the slight "ew"-ness of that, are there any other problems?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60833/new/

https://reviews.llvm.org/D60833





More information about the llvm-commits mailing list