[PATCH] D60806: [HWASan] Added no-FP unit test for register dump.

Thu Apr 18 16:30:04 PDT 2019

hctim added inline comments.

================
Comment at: compiler-rt/test/hwasan/TestCases/register-dump-no-fp.cc:2
+// RUN: %clangxx_hwasan -ffixed-x10 -ffixed-x20 -ffixed-x27 \
+// RUN:   -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -O0 %s -o %t && \
+// RUN:   not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK
----------------
eugenis wrote:
> hctim wrote:
> > eugenis wrote:
> > > You are testing the case when f() does NOT have a frame pointer - why add these flags? 
> > Is this in reference to the `-ffixed-*` flags? Assuming it is, have removed.
> No, I meant *no-omit* flags. You are testing the case then f() does NOT have a frame pointer. These flags ADD frame pointer to all functions. The test case only works because they fail to apply to f() for unknown reason.
> 
Ack. Missed the double negative on the flag :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60806/new/

https://reviews.llvm.org/D60806