[PATCH] D60858: AMDGPU: Skip debug instructions in assert

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 14:05:09 PDT 2019


echristo added a comment.

Sure. I'd have probably just checked for the function and maybe an instruction or two rather than the whole thing. It's more fragile that way and harder to understand what you're actually checking for since you mostly just said "doesn't crash" :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60858/new/

https://reviews.llvm.org/D60858





More information about the llvm-commits mailing list