[PATCH] D59918: [Attributor] Pass infrastructure and fixpoint framework

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert marked 3 inline comments as done.
jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:255-261
+/// ----------------------------------------------------------------------------
+///                       Abstract Attribute Classes
+/// ----------------------------------------------------------------------------
+
+/// ----------------------------------------------------------------------------
+///                       Pass (Manager) Boilerplate
+/// ----------------------------------------------------------------------------
----------------
chandlerc wrote:
> Note that these use doxygen syntax but aren't actually doxygen comments or terribly useful for that IMO.
> 
> I'd much rather more detailed doxygen comments on the specific types than trying to partition up the code into sections. Just my preference.
I did so in the header now, except the last "section" comment. I thought/hoped these will help read and extend the files later on. If that hope is not shared I can remove them everywhere.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:179
+  // annotation positions we use the underlying AttributeList interface.
+  // Note that MP_CALL_SITE_ARGUMENT can annotate multiple locations.
+
----------------
jdoerfert wrote:
> That note, and the ability to annotate multiple call sites at once, will be removed in the next update.
I'm still debating with myself if this is necessary/useful or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59918/new/

https://reviews.llvm.org/D59918