[PATCH] D60784: [Object][XCOFF] Add intial support for parsing/dumping section header table.

[Sean Fertile via Phabricator via llvm-commits]

sfertile marked 2 inline comments as done and an inline comment as not done.
sfertile added inline comments.


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:24
 #include "llvm/Object/ObjectFile.h"
 #include "llvm/Object/SymbolicFile.h"
 #include "llvm/Support/Casting.h"
----------------
sfertile wrote:
> sfertile wrote:
> > DiggerLin wrote:
> > > ObjectFile.h already include SymbolicFile.h , I think there do need SymbolicFile.h here. and also 
> > > #include "llvm/Object/Binary.h"
> > > #include "llvm/Object/Error.h"
> > > #include "llvm/BinaryFormat/Magic.h"
> > > #include "llvm/ADT/iterator_range.h"
> > > 
> > Good point, most of these are already included from ObjectFile.h. I'll clean up our header includes but I'll land that in a separate NFC patch.
> Didn't intend to mark this done yet.
Posted: https://reviews.llvm.org/D60885. I plan to commit that Monday or Tuesday and then I'll rebase this patch to pick up the changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60784/new/

https://reviews.llvm.org/D60784