[PATCH] D60669: [APInt] Optimize umul_ov

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 12:43:47 PDT 2019


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM. It might still make sense to optimize the single word case separately, but for the general case I don't think we can do much better than this.



================
Comment at: lib/Support/APInt.cpp:1919
+    Overflow = true;
+    return operator*(RHS);
+  }
----------------
Is there a reason to use `operator*(RHS)` over `*this * RHS` here?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60669/new/

https://reviews.llvm.org/D60669





More information about the llvm-commits mailing list