[PATCH] D60846: [ValueTracking] Improve isKnowNonZero for Ints

[Dan Robertson via Phabricator via llvm-commits]

dlrobertson marked 2 inline comments as done.
dlrobertson added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/cttz.ll:12
+; CHECK:       non_zero:
+; CHECK-NEXT:    [[CTZ:%.*]] = call i64 @llvm.cttz.i64(i64 [[X]], i1 false), !range !0
+; CHECK-NEXT:    [[CTZ32:%.*]] = trunc i64 [[CTZ]] to i32
----------------
nikic wrote:
> Hm, it looks like the optimization we want doesn't actually happen here? The `i1 false` should have changed to an `i1 true`.
Good catch. Just a cast of not updating the patch I uploaded.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60846/new/

https://reviews.llvm.org/D60846