[PATCH] D60052: Add Connex vector processor back end
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 18 05:49:58 PDT 2019
asb added a comment.
Some initial feedback:
- This patch is pretty huge which makes it pretty hard to meaningfully review
- There seem to be effectively no tests. I'd expect test/CodeGen/Connex and test/MC/Connex to be reasonably well populated
- Plenty of code commented out or with date-based comments that don't match our style, e.g. `// 2018_*`
- Files have the old license header rather than the new one
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60052/new/
https://reviews.llvm.org/D60052
More information about the llvm-commits
mailing list