[PATCH] D60785: [ELF] Align file offset for .bss if first section in a PT_LOAD

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 05:47:02 PDT 2019


MaskRay added inline comments.


================
Comment at: lld/ELF/Writer.cpp:2221
+  if (!OS->PtLoad) {
+    // File offsets are not significant for .bss sections when not the first
+    // section in a PT_LOAD. By convention, we keep section offsets
----------------
`when not the first section in a PT_LOAD` -> `not in a PT_LOAD`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60785/new/

https://reviews.llvm.org/D60785





More information about the llvm-commits mailing list