[PATCH] D60858: AMDGPU: Skip debug instructions in assert

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 04:48:42 PDT 2019


arsenm added a comment.

In D60858#1471490 <https://reviews.llvm.org/D60858#1471490>, @echristo wrote:

> FWIW they're fine IMO too :)
>
> Testcase and match seem a little long - any chance of shrinking either?


This is as far as I was able to get for an IR test. Any further probably requires a MIR testcase. However, the MIR printer and parser don’t correctly handle debug info references in DBG_VALUE. I discovered recently it mostly works if you strip out all the operands to them, but I’m not sure that will work here. I assume the pass reinserting these actually needs the operands to get the same position


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60858/new/

https://reviews.llvm.org/D60858





More information about the llvm-commits mailing list