[PATCH] D57504: RFC: Prototype & Roadmap for vector predication in LLVM

Thu Apr 18 01:33:52 PDT 2019

simoll planned changes to this revision.
simoll added a comment.

Thanks for your feedback!

Planned
-------

- Make the `llvm.vp.constrained.*` versions the only fp ops in vp. Encode default fp semantics by passing `fpexcept.ignore` and `round.tonearest`.
- Update `docs/AddingConstrainedIntrinsics.rst` to account for the fact that `llvm.experimental.constrained.*` is no longer the only namespace for constrained intrinsics.

In D57504#1470705 <https://reviews.llvm.org/D57504#1470705>, @kpn wrote:

> Would it make sense to also update docs/AddingConstrainedIntrinsics.rst please?

Sure. I don't think we should match (in the API) an `llvm.vp.constrained.*` intrinsic as `ConstrainedFPIntrinsic` though.
Conceptually, an `llvm.vp.constrained.*` intrinsics sure is both - `VPIntrinsic` and `ConstrainedFPIntrinsic`. If the latter is used to transform them, ignoring the mask an vector len argument along the way, we'll see breakage (..in the future, once there are transforms for constrained fp).

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57504/new/

https://reviews.llvm.org/D57504