[PATCH] D60820: [yaml2elf/obj2yaml] - Allow normal parsing/dumping of the .rela.dyn section.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with two nits.



================
Comment at: test/tools/obj2yaml/elf-reladyn-section-shinfo.yaml:2
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-readobj -sections %t | FileCheck %s
+# RUN: obj2yaml %t | FileCheck %s --check-prefix=YAML
----------------
There's some discussion about removing support for long single-dash options in llvm-readobj, so it's probably best to use double dash here (i.e. --sections).


================
Comment at: test/tools/obj2yaml/elf-reladyn-section-shinfo.yaml:7
+## no value in sh_info field. Check we are able to use
+## yaml2obj/obj2yaml without need to explicitly set it.
+
----------------
need -> needing


================
Comment at: test/tools/obj2yaml/elf-reladyn-section-shinfo.yaml:41
+    EntSize: 0x0000000000000018
+# Add at least one symbol to trigger the .dynsym emission
+DynamicSymbols:
----------------
Nit: needs a trailing full stop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60820/new/

https://reviews.llvm.org/D60820