[llvm] r358644 - [PowerPC] Fix wrong ElemSIze when calling isConsecutiveLS()
Kang Zhang via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 18 00:24:15 PDT 2019
Author: zhangkang
Date: Thu Apr 18 00:24:15 2019
New Revision: 358644
URL: http://llvm.org/viewvc/llvm-project?rev=358644&view=rev
Log:
[PowerPC] Fix wrong ElemSIze when calling isConsecutiveLS()
Summary:
This issue from the bugzilla: https://bugs.llvm.org/show_bug.cgi?id=41177
When the two operands for BUILD_VECTOR are same, we will get assert error.
llvm::SDValue combineBVOfConsecutiveLoads(llvm::SDNode*, llvm::SelectionDAG&):
Assertion `!(InputsAreConsecutiveLoads && InputsAreReverseConsecutive) &&
"The loads cannot be both consecutive and reverse consecutive."' failed.
This error caused by the wrong ElemSIze when calling isConsecutiveLS(). We
should use `getScalarType().getStoreSize();` to get the ElemSize instread of
`getScalarSizeInBits() / 8`.
Reviewed By: jsji
Differential Revision: https://reviews.llvm.org/D60811
Added:
llvm/trunk/test/CodeGen/PowerPC/pr41177.ll
Modified:
llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp
Modified: llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp?rev=358644&r1=358643&r2=358644&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp Thu Apr 18 00:24:15 2019
@@ -12175,7 +12175,7 @@ static SDValue combineBVOfConsecutiveLoa
SDLoc dl(N);
bool InputsAreConsecutiveLoads = true;
bool InputsAreReverseConsecutive = true;
- unsigned ElemSize = N->getValueType(0).getScalarSizeInBits() / 8;
+ unsigned ElemSize = N->getValueType(0).getScalarType().getStoreSize();
SDValue FirstInput = N->getOperand(0);
bool IsRoundOfExtLoad = false;
Added: llvm/trunk/test/CodeGen/PowerPC/pr41177.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/PowerPC/pr41177.ll?rev=358644&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/PowerPC/pr41177.ll (added)
+++ llvm/trunk/test/CodeGen/PowerPC/pr41177.ll Thu Apr 18 00:24:15 2019
@@ -0,0 +1,12 @@
+; RUN: llc -verify-machineinstrs -mcpu=pwr9 -mtriple=powerpc64le-unknown-linux-gnu < %s
+; REQUIRES: asserts
+
+define protected swiftcc void @"$s22LanguageServerProtocol13HoverResponseV8contents5rangeAcA13MarkupContentV_SnyAA8PositionVGSgtcfC"() {
+ %1 = load <2 x i64>, <2 x i64>* undef, align 16
+ %2 = load i1, i1* undef, align 8
+ %3 = insertelement <2 x i1> undef, i1 %2, i32 0
+ %4 = shufflevector <2 x i1> %3, <2 x i1> undef, <2 x i32> zeroinitializer
+ %5 = select <2 x i1> %4, <2 x i64> zeroinitializer, <2 x i64> %1
+ store <2 x i64> %5, <2 x i64>* undef, align 8
+ ret void
+}
More information about the llvm-commits
mailing list