[PATCH] D60487: [llvm] Prevent duplicate files in debug line header in dwarf 5: another attempt

[Eric Christopher via Phabricator via llvm-commits]

echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

OK, this code could use some work, but not for you to refactor it more than you already have.

One change: Please change your use of MCContext in the patch with an unsigned DwarfVersion and pass that down instead. There is, sadly, nothing else that can be minimized by passing the context and it's just a little more confusing. Conveniently you can get the version anywhere you were getting the context so it should be a mechanical change.

LGTM with that change. Feel free to commit without uploading another version at that point.

Thanks!

-eric


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60487/new/

https://reviews.llvm.org/D60487