[PATCH] D60131: [ELF] Change default output section type to SHT_PROGBITS

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

IIUC, you are fixing an issue that a segment whose size is 0 doesn't have a file offset that is congruent modulo page size. Is this correct?

The file offset for an empty segment is not actually significant; we can just set a dummy value. Have you considered that?



================
Comment at: test/ELF/linkerscript/orphan-phdrs.s:1
+# XFAIL: *
+
----------------
We shouldn't keep a test that doesn't run at all. Please just remove.


================
Comment at: test/ELF/linkerscript/symbol-only-align.test:2-5
+# RUN: echo '.text; \
+# RUN:        ret;  \
+# RUN:       .data; \
+# RUN:       .quad 0' > %t.s
----------------
nit: You can just write them in a single line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60131/new/

https://reviews.llvm.org/D60131