[PATCH] D50407: Remove obsolete policy settings

Wed Apr 17 18:38:02 PDT 2019

smeenai added inline comments.

================
Comment at: llvm/trunk/CMakeLists.txt:16

-cmake_policy(SET CMP0056 NEW)
-
----------------
smeenai wrote:
> This removal was incorrect. https://cmake.org/cmake/help/v3.4/policy/CMP0056.html says "Unlike most policies, CMake version 3.4.3 does not warn by default when this policy is not set and simply uses OLD behavior (and even the latest version's documentaion says the same).
> 
> In general, @beanz, @phosek, @mgorny and I make good reviewers for CMake changes.
Ah, nevermind, the document you linked seems more authoritative than the individual policy page's one. That's confusing documentation though.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50407/new/

https://reviews.llvm.org/D50407