[PATCH] D60095: [LLD][COFF] Move PDB type server loading from PDB.cp early into InputFiles.cpp and introduce PDBInputFile

[Takuto Ikuta via Phabricator via llvm-commits]

takuto.ikuta added inline comments.


================
Comment at: COFF/InputFiles.cpp:44
 
 using namespace llvm;
 using namespace llvm::COFF;
----------------
better to not have llvm:: prefix for type in this code when we have this?


================
Comment at: COFF/InputFiles.cpp:722
+// Make a PDB path assuming the PDB is in the same folder as the OBJ
+static std::string getPdbBaseName(ObjFile *File, StringRef TSPath) {
+  StringRef LocalPath =
----------------
const ObjFile *File ?


================
Comment at: COFF/InputFiles.cpp:745
+static Optional<std::string> findPdbPath(StringRef PDBPath,
+                                         ObjFile *DependentFile) {
+  // Ensure the file exists before anything else. In some cases, if the path
----------------
can be const ObjFile * here too?


================
Comment at: COFF/InputFiles.cpp:758
+
+Expected<PDBInputFile> PDBInputFile::findFromFile(ObjFile *DependentFile) {
+  const TypeServer2Record &TS =
----------------
same here?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60095/new/

https://reviews.llvm.org/D60095