[PATCH] D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests.

Wed Apr 17 10:39:11 PDT 2019

asbirlea marked 2 inline comments as done.
asbirlea added inline comments.

================
Comment at: test/Other/opt-O2-pipeline.ll:160
+; CHECK-NEXT:         Function Alias Analysis Results
+; CHECK-NEXT:         Memory SSA
 ; CHECK-NEXT:         Natural Loop Information
----------------
asbirlea wrote:
> chandlerc wrote:
> > This is weird.
> > 
> > If simplify loops and LCSSA aren't using MemorySSA we shouldn't be building it here only to trash it and rebuild it below. This will basically double the compile time cost (from building).
> To clarify this in writing, yes, currently MemorySSA is built twice in the old pass manager, due to the order of analysis. LoopSimplify and LCSSA need to preserve MemorySSA to resolve this.
> 
> The new pass manager does not have this issue.
Added dependent revisions that update LCSSA and LoopSimplify. PTAL.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58311/new/

https://reviews.llvm.org/D58311