[PATCH] D60265: [LoopUnroll] Allow unrolling if the unrolled size does not exceed loop size.

Wed Apr 17 08:56:29 PDT 2019

fhahn added a comment.

In D60265#1455100 <https://reviews.llvm.org/D60265#1455100>, @paquette wrote:

> In D60265#1455091 <https://reviews.llvm.org/D60265#1455091>, @fhahn wrote:
>
> > Right, I should have said something here. Without D60266 <https://reviews.llvm.org/D60266>, there was no change in code size on the set of benchmarks, most likely because loop-rotate is not run and they are not in the required form for unrolling to happen.
>
>
> Ok, cool!
>
> > I guess it would be sufficient to drop minsize from the attribute list, assuming minsize always come with optsize?
>
> minsize only comes with optsize when your function is effectively -Oz. If your function is -Os, it will only have optsize.
>
> So, I would keep them both since -Oz behaviour is more important here (IMO). If you want to test both I guess you'll have to duplicate the test, sadly.

Thanks, I've added a test that uses { midsize optsize } and switched the rest to {optsize}

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60265/new/

https://reviews.llvm.org/D60265