[PATCH] D60324: [llvm-objcopy] Add switch to allow removing referenced sections

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht accepted this revision.
rupprecht added a comment.

Sorry, I should have just accepted this before -- the option missing from strip is my only objection. The rest are just suggestions.



================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:436
+          llvm::errc::invalid_argument,
+          "String table %s cannot be removed because it is "
+          "referenced by the symbol table %s",
----------------
jhenderson wrote:
> rupprecht wrote:
> > We could make these error messages more helpful by saying something like:
> > 
> > String table cannot be removed ... Rerun with -R $name to also remove this section, or --allow-broken-links to suppress this error
> I don't disagree, but can this be a subsequent patch, as it affects an error message that isn't currently changing?
Yep, that's fine.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60324/new/

https://reviews.llvm.org/D60324