[PATCH] D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 17 02:36:35 PDT 2019


jhenderson added inline comments.


================
Comment at: test/tools/llvm-symbolizer/output-style-empty-line.test:18
+
+GNU: x.c:14
+GNU-NEXT: some text2
----------------
ikudrin wrote:
> jhenderson wrote:
> > Put a `{{$}}` at the end of this line, if you don't want it matching the column output.
> I am trying to follow the rule that the test should check only one specific thing, if possible. This very test checks only the presence or absence of an empty line. There is another test, 'output-style-column.test', which checks for the column.
Okay, fair enough.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60770/new/

https://reviews.llvm.org/D60770





More information about the llvm-commits mailing list