[PATCH] D60067: [llvm-symbolizer] Add llvm-addr2line.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D60067#1469782 <https://reviews.llvm.org/D60067#1469782>, @ikudrin wrote:

> In D60067#1468404 <https://reviews.llvm.org/D60067#1468404>, @jhenderson wrote:
>
> > Code all looks good, but you should talk about the effect of --output-style on the output for both llvm-symbolizer and llvm-addr2line as appropriate.
>
>
> Do you want this option to be added to the documentation about `llvm-symbolizer` or something else? Or you meant other places where this info should be added?


It would be good to have it in the llvm-symbolizer document (if it doesn't already exist there), documenting the style differences. I think it should also be explicitly mentioned in the llvm-addr2line document (but just saying the default is different is fine for that).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60067/new/

https://reviews.llvm.org/D60067