[PATCH] D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 23:53:50 PDT 2019


ikudrin marked an inline comment as done.
ikudrin added inline comments.


================
Comment at: test/tools/llvm-symbolizer/output-style.test:1
-RUN: llvm-symbolizer -e %p/Inputs/addr.exe 0x40054d \
-RUN:   | FileCheck %s --check-prefix=LLVM
+RUN: llvm-symbolizer -i -e %p/Inputs/addr.exe < %p/Inputs/addr.inp \
+RUN:   | FileCheck %s --check-prefix=LLVM_I
----------------
jhenderson wrote:
> This test is getting too big to follow. I wonder if it would be better to add llvm-symbolizer --output-style=GNU/LLVM cases to the existing tests for -i/-p?
It was my first intention but it looked even worse.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60770/new/

https://reviews.llvm.org/D60770





More information about the llvm-commits mailing list