[llvm] r358557 - Fixed error message printing in write_cmake_config.py

Dmitri Gribenko via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 23:11:27 PDT 2019


Author: gribozavr
Date: Tue Apr 16 23:11:27 2019
New Revision: 358557

URL: http://llvm.org/viewvc/llvm-project?rev=358557&view=rev
Log:
Fixed error message printing in write_cmake_config.py

Summary:
Previously, write_cmake_config.py would raise an error while printing
the error, because `leftovers` in "'\n'.join(leftovers)" is a tuple.

Subscribers: mgorny, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D60766

Modified:
    llvm/trunk/utils/gn/build/write_cmake_config.py

Modified: llvm/trunk/utils/gn/build/write_cmake_config.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/build/write_cmake_config.py?rev=358557&r1=358556&r2=358557&view=diff
==============================================================================
--- llvm/trunk/utils/gn/build/write_cmake_config.py (original)
+++ llvm/trunk/utils/gn/build/write_cmake_config.py Tue Apr 16 23:11:27 2019
@@ -96,7 +96,10 @@ def main():
 
     leftovers = var_re.findall(output)
     if leftovers:
-        print('unprocessed values:\n', '\n'.join(leftovers), file=sys.stderr)
+        print(
+            'unprocessed values:\n',
+            '\n'.join([x[0] or x[1] for x in leftovers]),
+            file=sys.stderr)
         return 1
 
     if not os.path.exists(args.output) or open(args.output).read() != output:




More information about the llvm-commits mailing list