[PATCH] D60794: [libcxx][CMake] Add an option to include -lgcc_s in the linker script

[Eric Fiselier via Phabricator via llvm-commits]

EricWF added a comment.

I don't think this is correct.

The compiler should be linking gcc unwind for us, and there should be no need for users to link it themselves.

We only do it in the test suite because we can't drop the C++ standard library without dropping the rest of the link line (At least before `-nostdlibc++` existed).

Also I don't think a libc++ build is tied to any one particular unwind library?



================
Comment at: libcxx/utils/libcxx/test/target_info.py:253
+        # None          | gcc | gcc
+        #
         if llvm_unwinder and not libcxx_is_linker_script:
----------------
We really should be replacing this whole thing with `-nostdlib++` (And I would if GCC supported it).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60794/new/

https://reviews.llvm.org/D60794