[PATCH] D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, induction variable, and guard branch.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: llvm/unittests/Analysis/LoopInfoTest.cpp:236-254
+      "define void @foo(i32* %A, i32 %ub) {\n"
+      "entry:\n"
+      "  %guardcmp = icmp slt i32 0, %ub\n"
+      "  br i1 %guardcmp, label %for.preheader, label %for.end\n"
+      "for.preheader:\n"
+      "  br label %for.body\n"
+      "for.body:\n"
----------------
Whitney wrote:
> Meinersbur wrote:
> > [suggestion] This is easier to format using C++11 raw strings. See `unittests/Transforms/Utils/UnrollLoopTest.cpp`.
> I can change to using C++11 raw strings, but then these new test cases will be different than all other test cases in this unit test file `LoopInfoTest.cpp`. What do you think?
This is just a suggestion. You can do what you think what's more appropriate, unless others have stronger opinions.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60565/new/

https://reviews.llvm.org/D60565