[PATCH] D55290: [docs] Update llvm.loop metadata documentation.

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 15:23:25 PDT 2019


hfinkel added inline comments.


================
Comment at: docs/LangRef.rst:5099
+For legacy reasons, the first item of a loop metadata node must be a
+reference to itself. It was used to avoid collapsing of multiple loop
+metadata nodes into one. Also, the 'distinct' keyword for loop-metadata
----------------
Before the advent of the 'distinct' keyword, this forced the preservation of otherwise-identical metadata nodes.


================
Comment at: docs/LangRef.rst:5103
+
+In addition to property nodes, the loop metadata list node can up to two
+debug info nodes of type ``DILocation``. The first of it in the list, if
----------------
can have up to


================
Comment at: docs/LangRef.rst:5103
+
+In addition to property nodes, the loop metadata list node can up to two
+debug info nodes of type ``DILocation``. The first of it in the list, if
----------------
hfinkel wrote:
> can have up to
Prior to the property nodes, one or two ``DILocation`` (debug location) nodes can be present in the list. The first, if present, identifies the source-code location where the loop begins. The second, if present, identifies the source-code location where the loop ends.


================
Comment at: docs/LangRef.rst:5108
+
+Loop metadata nodes cannot be used as identifiers. They are neither
+persistent for the same loop through pass transformations
----------------
as unique identifiers


================
Comment at: docs/LangRef.rst:5109
+Loop metadata nodes cannot be used as identifiers. They are neither
+persistent for the same loop through pass transformations
+nor necessarily unique to just one loop.
----------------
through transformations


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55290/new/

https://reviews.llvm.org/D55290





More information about the llvm-commits mailing list