[PATCH] D60798: [HWASan] Fixed slow DWARF unwinding.

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 15:08:42 PDT 2019


hctim created this revision.
hctim added a reviewer: eugenis.
Herald added subscribers: llvm-commits, Sanitizers, javed.absar, kubamracek.
Herald added projects: Sanitizers, LLVM.

CFA was setup incorrectly, as there is an 8-byte gap at the top of the stack for SP 16-byte alignment purposes.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60798

Files:
  compiler-rt/lib/hwasan/hwasan_tag_mismatch_aarch64.S


Index: compiler-rt/lib/hwasan/hwasan_tag_mismatch_aarch64.S
===================================================================
--- compiler-rt/lib/hwasan/hwasan_tag_mismatch_aarch64.S
+++ compiler-rt/lib/hwasan/hwasan_tag_mismatch_aarch64.S
@@ -68,9 +68,9 @@
   // __hwasan_tag_mismatch. The frame pointer is already correctly setup
   // by __hwasan_check_*.
   add x29, sp, #232
-  CFI_DEF_CFA(w29, 16)
-  CFI_OFFSET(w30, -8)
-  CFI_OFFSET(w29, -16)
+  CFI_DEF_CFA(w29, 24)
+  CFI_OFFSET(w30, -16)
+  CFI_OFFSET(w29, -24)
 
   // Save the rest of the registers into the preallocated space left by
   // __hwasan_check.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60798.195470.patch
Type: text/x-patch
Size: 622 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190416/cca3bd0c/attachment.bin>


More information about the llvm-commits mailing list