[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 13:45:31 PDT 2019

Previous message: [PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types
Next message: [PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

craig.topper added a comment.

Wondering if it would be better to assert for asking for the sign of an unsigned APSInt. I could see a caller just wanting to get the msb for some reason and not knowing that isNegative won’t work.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59712/new/

https://reviews.llvm.org/D59712

Previous message: [PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types
Next message: [PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list