[PATCH] D60750: [libc++][CMake] Clean up logic for choosing which unwinder lib to link with tests

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 12:58:17 PDT 2019


tstellar marked an inline comment as done.
tstellar added inline comments.


================
Comment at: libcxx/utils/libcxx/test/target_info.py:251
+            # FIXME: Why is -lgcc needed for the unwinder?
+            flags += ['-lgcc_s', '-lgcc']
+        # If we are using a linker script and llvm_unwinder is eanbled, then we
----------------
phosek wrote:
> `-lgcc` is `libgcc.a`, `-lgcc_s` is `libgcc_s.so.1`, you probably only want one of those?
This was my question.  I wasn't sure why both were included.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60750/new/

https://reviews.llvm.org/D60750





More information about the llvm-commits mailing list