[PATCH] D60746: [BlockExtractor] Extend the file format to support the grouping of basic blocks

Volkan Keles via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 11:15:48 PDT 2019


volkan added a comment.

Hi Quentin,

This looks good to me, but seems like a bit complicated. I think we can simplify the logic by getting basic block groups as a comma separated string.
For example:

  foo bb1 ;; Extract bb1 in its own function
  foo bb2,bb3 ;; Extract bb2 and bb3 in their own function

What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60746/new/

https://reviews.llvm.org/D60746





More information about the llvm-commits mailing list